rdk: remove dangling raspi reference - #11508
Conversation
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes support and references for the Raspberry Pi (raspi/raspi-2) platform across configuration, test, and build files. The review feedback points out that removing the rdk-rpi specific system_gles2.cc override in BUILD.gn could break the rdk-rpi target if it is still supported, and suggests either moving the Raspberry Pi-specific GLES initialization code to the rdk directory or cleaning up the rdk-rpi target entirely.
I am having trouble creating individual review comments. Click here to see my feedback.
starboard/contrib/rdk/src/third_party/starboard/rdk/shared/BUILD.gn (299-306)
Simply removing the rdk-rpi specific system_gles2.cc override will cause the rdk-rpi target to fall back to the generic //starboard/shared/gles/system_gles2.cc. If rdk-rpi is still a supported target, it likely requires the Raspberry Pi-specific GLES/EGL initialization that was previously in //starboard/raspi/shared/system_gles2.cc. If so, that file should be copied/moved to the rdk directory (e.g., starboard/contrib/rdk/shared/system_gles2_rpi.cc) and referenced here, rather than completely removing the override. If rdk-rpi is no longer supported, the target itself should be cleaned up.
5dd85d2 to
949534d
Compare
949534d to
4790633
Compare
anshugupta27
changed the title
- Remove broken reference to //starboard/raspi/shared/system_gles2.cc in starboard/contrib/rdk/src/third_party/starboard/rdk/shared/BUILD.gn. - Delete deprecated evergreen-arm-hardfp-raspi package.
4790633 to
2f163b3
Compare
| sources += [ "speech/speech_synthesis_is_supported_executable.cc", ] | ||
| } | ||
|
|
||
| if (starboard_target_platform == "rdk-rpi") { |
There was a problem hiding this comment.
it says rdk here, maybe this is still relevant for that platform?
maybe double-check that this won't effect RDK or if it does, we might need to fix the starboard_target_platform name so that rdk and raspi are decoupled
There was a problem hiding this comment.
Looks irrelevant, this isn't used a starboard_target_platform. @niranjanyardi ptal
3 participants
The starboard/raspi directory has been deleted as part of the raspi-2 deprecation. This removes the dangling reference to //starboard/raspi/shared/system_gles2.cc for the rdk-rpi target.
Bug: 500021808